Repository navigation
Curate base-dev for the desk via peru - #332
Merged
Merged
Conversation
The new kernel builds every mark present on a desk, so rsyncing all of urbit's pkg/base-dev (~92 files) onto the landscape desk pulled in unused marks that fail to compile. Vendor only the transitive closure of desk/'s imports via peru (peru.yaml, pinned to 408k-rc2) into a gitignored desk-deps/, and assemble desk-deps/ + desk/ in the deploy runner. - peru.yaml: 10 lib, 2 sur, 10 mar picks from base-dev - scripts/sync-deps.sh, scripts/assemble-desk.sh - deploy.sh: assemble in runner, scp tarball, remote only mounts/commits - drop now-unused URBIT_REPO_TAG from deploy workflows (rev pinned in peru.yaml) - delete dead files desk/lib/graph-store.hoon, desk/sur/activity.hoon Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The assembled desk tarball is shipped up through gcloud's single-threaded IAP websocket proxy; without NumPy that upload takes ~4 min. Matches the tlon-apps deploy.sh fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues with desk ops now that the kernel is more strict about marks compiling, also updates our workflow to be more intentional around desk dependencies.
Reference
Mirrors tloncorp/tlon-apps#5949 for landscape.
What & why
The new kernel builds every mark present on a desk. The old deploy did
rsync -avL --delete pkg/base-dev/— dumping all ~92 base-dev files onto the landscape desk — so unused marks (language-server,umd,png,woff2, …) got compiled and could break the build on the target kelvin.This vendors only the transitive closure of
desk/'s imports via peru into a gitignoreddesk-deps/, then assemblesdesk-deps/+desk/in the deploy runner.Changes
peru.yaml— picks 10 lib / 2 sur / 10 mar fromurbit/urbitpkg/base-dev, pinned to408k-rc2(matchesdesk/sys.kelvin).scripts/sync-deps.sh/scripts/assemble-desk.sh—peru sync, then layerdesk-deps/(with--delete) +desk/..github/helpers/deploy.sh— assemble the desk in the runner,scpa tarball to the ship; the remote only unpacks/mounts/commits (no more cloning urbit on the ship). The remote--deletepurges stale base-dev files from existing ships.URBIT_REPO_TAGenv (rev is owned byperu.yaml)..gitignore—desk-deps/,.peru/,peru.lock.desk/lib/graph-store.hoonanddesk/sur/activity.hoon— dead files importing surs (hark-store,contacts) that don't exist on the desk; nothing references them.Verification
peru syncresolves all 22 picks against408k-rc2./+//-imports resolve, zero exceptions.Follow-ups
URBIT_REPO_TAG/URBIT_REPO_TAG_KERNELrepo Actions variables are now unused and can be deleted from settings.