Skip to content

Php8 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jabqooo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Php8 #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ff35d5
Merge pull request #1 from tlapnet/master
Jabqooo Aug 26, 2020
b01f152
Merge branch 'tlapnet:master' into master
Jabqooo Jan 26, 2022
d5a65e9
php 8: add default values
Jabqooo Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Bridges/Chart/Renderers/AbstractChartRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected function getSeriesBys(): array
/**
* @param mixed[] $conditions
*/
public function addSerie(array $conditions = [], string $type, string $title, ?string $color = null, ?string $group = null): void
public function addSerie(array $conditions = [], string $type = '', string $title = '', ?string $color = null, ?string $group = null): void
{
// Generate unique serie ID
$sid = md5(serialize([$conditions, $type, $title, $color]));
Expand Down