Add support for specifying custom SSH port of a managed server#74
Open
nstojiljkovic wants to merge 1 commit into
Open
Add support for specifying custom SSH port of a managed server#74nstojiljkovic wants to merge 1 commit into
nstojiljkovic wants to merge 1 commit into
Conversation
|
LGTM. |
Owner
|
Hey @nstojiljkovic, first of all, thanks a lot for your PR! 🎉 I'm sorry but I'm currently not finding time to properly support this as needed, also sorry for not getting back to you earlier! :-( Currently the failing build prevents the merge. But before merging, I would like to (ideally in a separate PR):
I will try to find some time during the next days. If you want to support, I'm happy about PRs as well. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying custom SSH port of a managed server. No new configuration option is added, the port should be specified in the existing
serverconfiguration option in a standard format, e.g.192.168.0.1:8022(for port 8022). It supports IPv6, for example by specifyingserverto be[::1]:8022. The presented solution is also backwards compatible.Solution with configuring
override.sshpresented in #53 is not optimal when port forwarding is used on a localhost to multiple servers as all of them will share the same internalidin Vagrant.This closes issue #53.