Fix overflow parsing large float exponents#20
Merged
Conversation
Parsing huge exponents results in a signed overflow (UB). In practice it likely wraps to an incorrect KDL number for the input. The fix includes a test that fails without it.
Owner
|
Ok, wow. It took me a moment to understand what the actual issue was. Beautiful and astonishing UBsan find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing huge exponents results in a signed overflow (UB). In practice it likely wraps to an incorrect KDL number for the input. The fix includes a test that fails without it.
To demonstrate the bug two ways at once:
First, UBSan detects signed overflow, then an incorrect result of 1.0 due to wrapping.