feat(registry): unified CheckRegistry and granular rule execution (tff#146) - #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What changed?
CheckRegistryandCheckDefinitioninpackages/tff-core/src/tff/core/registry.pydefining typed metadata (id,label,category,scope,default_severity,aliases,finding_check_id, lazy dynamic loader for rule classes / collector functions, andis_enabled_fn).health.py(CATEGORIES,is_check_enabled,PROJECT_LEVEL_CHECKS) andreport.py(CHECK_LABELS,CONNASCENCE_CATEGORIES,ARCHITECTURAL_CHECKS) with single-source-of-truth registry queries.run_all_checksacross dbt (tff.dbt.runner), Dataform (tff.dataform.runner), and SQLMesh (tff.sqlmesh.runner) to support granular check execution viaregistry.run_checks(..., checks=...)while maintaining 100% backward compatibility for container keys ("rules","sqlmesh") and legacy check aliases.packages/tff-core/tests/test_registry.pycovering registry lookups, resolution, fallback runners, and granular check execution across dbt, Dataform, and SQLMesh runners..githooks/pre-push.🤔 Why is this change needed?
Resolves issue #146 (Phase 3 of the architectural improvements):
health.py,report.py, and runner modules.tff lint --checks no_missing_owner,ban_select_staron dbt, Dataform, and SQLMesh projects.🔗 Related Issues (Optional)
Closes #146
✅ Next Steps / Checklist (Optional)
README.md