refactor(adapters): implement polymorphic PipelineAdapter interface (#145) - #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What changed?
PipelineAdapterabstract base class intff.core.adapterdefining unified lifecycle methods:provider_name,is_applicable,load_models,run_checks,apply_metadata_fix, andget_diagnostic_files.DBTAdapterintff.dbt.adapterSQLMeshAdapterintff.sqlmesh.adapterDataformAdapterintff.dataform.adapterdbt/runner.py,sqlmesh/runner.py,dataform/runner.py) to accept an optional preloadedmodels: dict[str, ModelRepresentation] | None = None.tff.core.docs.generate_docs_dashboardto eliminate procedural branching and eliminate duplicate manifest/context model loading by reusing preloaded models inrun_checks.tff.core.autofix.apply_autofixesto dispatch metadata fixes polymorphically viaadapter.apply_metadata_fix(...)instead of hardcoded provider checks.tff.core.clito usedetect_providerand_get_adapter(provider), eliminating provider ladders ininfo,lint, andhealth, while introducing_MockRunnerAdapterto preserve complete backwards compatibility for existing tests mocking_get_runner.packages/tff-core/tests/test_adapter.pyachieving 100% diff test coverage.🤔 Why is this change needed?
Resolves issue #145:
tff-core, CLI commands (info,lint,health),docs.py, andautofix.pycontained hardcodedif provider == "dbt" ... elif provider == "sqlmesh" ... elif provider == "dataform"procedural ladders. Adding support for a new transformation engine required editing multiple disjoint files across the codebase.tff docsandtff lint --fix, models were compiled and loaded twice (first explicitly for mapping, and a second time inside the runner check execution), causing unnecessary compilation latency.🔗 Related Issues (Optional)
Closes #145
✅ Next Steps / Checklist (Optional)
PipelineAdapterbase class and provider registry implementedDBTAdapter,SQLMeshAdapter, andDataformAdapterimplemented