Docker MQTT deployment

[diogos88]

Modified your project to deploy with docker-compose and fix the configuration implementation (mqtt).

[titilambert]

Thanks for your PR. I put some comments, I just need to understand some of your changes.
Globally, I don't understand:

• Why you changed the dockerfile
• Why you changed the mqtt push data
• Why using docker-compose, when there is only one container ... a single docker command can do the trick

[titilambert]

Why are you doing this ?

[diogos88]

For the persistence of the mqtt config file. You want to create the file if it's missing in the config without overwriting it.

[titilambert]

I would not do that, I think it better to crash if the file doesn't exists instead of copying a bad config file. What do you think ?

[titilambert]

Why do you change the working dir ?

[diogos88]

I put everything in the same root folder instead of having one root folder for the code and one root folder for the config.

[titilambert]

OK, but /usr/SOMETHING it's a weird folder. I would use something like /usr/local/pyhydroquebec.
In fact, we are copyng application's sources, that's why I put /usr/src/app, but I should put /usr/local/src/pyhydroquebec.

What do you think using /usr/local/src/pyhydroquebec ?

[diogos88]

Thanks for the review,

Why you changed the dockerfile
I modified the dockerfile to integrate the mqtt portion and the persistence of the config file. With mqtt added in the dockerfile, it will simplify users integration in their environment and domotic application.

Why you changed the mqtt push data
This part was modified to only have one topic per account/contract_id. Correct me if I am wrong but the balance topic should be in the contract_id topic.

Why using docker-compose, when there is only one container ... a single docker command can do the trick
I use docker-compose because it's easier to read and structure, that's the only reason. At the end it's the same thing as a docker run command.

[titilambert]

Thanks for your answers !!

Why you changed the dockerfile
I modified the dockerfile to integrate the mqtt portion and the persistence of the config file. With mqtt added in the dockerfile, it will simplify users integration in their environment and domotic application.

I'm sorry but I still don't understand those changes in the Dockerfile. Today, I'm using the current master docker image with MQTT without any issue. What are the issues that you're a trying to solve with theses change ?

Why you changed the mqtt push data
This part was modified to only have one topic per account/contract_id. Correct me if I am wrong but the balance topic should be in the contract_id topic.

Thanks for this one !

Why using docker-compose, when there is only one container ... a single docker command can do the trick
I use docker-compose because it's easier to read and structure, that's the only reason. At the end it's the same thing as a docker run command.

OK, Thanks for this one too !

[titilambert]

BTW, I will handle the merge conflict (I created it ...)