Accept login-complete on /login so a second account can sign in - #6
Open
webscience2 wants to merge 1 commit into
Open
webscience2 wants to merge 1 commit into
webscience2 wants to merge 1 commit into
Conversation
OAuth returns through granola://login-complete, but the renderer only handles that callback on /login-in-progress. Adding another account often stays on /login, so the browser hands the URL back and the app ignores it. Same-length asar edit as the existing platform patch. Also register granola-dev:// for unpackaged Electron launches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OAuth comes back through
granola://login-complete(orgranola-dev://when Electron is launched unpackaged). The renderer only accepts that callback while it is on/login-in-progress.Adding a second account often never leaves
/login. The browser returns to the app, and the app logslogin-complete-ignored-not-on-login-in-progressand stays on the sign-in screen.Change
Same-length in-place asar edit as the existing platform patch: treat
isLoginInProgressRouteas true for that login-complete guard. The installer fails clearly if the bundled bytes have moved.Also register
x-scheme-handler/granola-devon the desktop entry. Unpackagedelectron /path/to/app.asarusesgranola-dev, notgranola.Notes
Jsn,c) will change if Granola's bundler output changes; the step exits instead of applying a bad patch.