fix: add errors="replace" to all subprocess.run calls in incremental.py#566
Open
lininn wants to merge 1 commit into
Open
fix: add errors="replace" to all subprocess.run calls in incremental.py#566lininn wants to merge 1 commit into
lininn wants to merge 1 commit into
Conversation
Prevents UnicodeDecodeError when git output contains non-UTF-8 or truncated multi-byte characters (e.g., branch names with CJK characters that get truncated by git rev-parse --abbrev-ref HEAD). The _git_branch_info function was crashing at full_build because it lacked errors='replace' on subprocess.run() calls, while other functions in the same file (e.g., _get_svn_changed_files, _read_ignore_file) already used errors='replace'. Also adds UnicodeDecodeError to except clauses so that any remaining decode failures are handled gracefully rather than crashing the build. Closes tirth8205#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents UnicodeDecodeError when git output contains non-UTF-8 or truncated multi-byte characters (e.g., branch names with CJK characters that get truncated by git rev-parse --abbrev-ref HEAD).
The _git_branch_info function was crashing at full_build because it lacked errors='replace' on subprocess.run() calls, while other functions in the same file (e.g., _get_svn_changed_files, _read_ignore_file) already used errors='replace'.
Also adds UnicodeDecodeError to except clauses so that any remaining decode failures are handled gracefully rather than crashing the build.
Closes #302
Pull Request
Linked issue
Closes #
What & why
How it was tested
Checklist
uv run pytest tests/ --tb=short -quv run ruff check code_review_graph/uv run mypy code_review_graph/ --ignore-missing-imports --no-strict-optionaldocs/, docstrings)