Skip to content

leg_voltage's comment calls luma3_h the eleventh leg; it is the twelfth #1

Description

@isenbek

crates/v2c02-dots/src/lib.rs, the doc comment on leg_voltage (around line 416), says "the eleventh, `luma3_h`, is read separately".

luma3_h is the twelfth: it is index 11 of a twelve-entry set, and the eleventh is LOW[3]. The die has twelve level legs (vid_sync_l/h, vid_burst_l/h, vid_luma0..3_l/h, aliased vid_0..vid_11), with vid_emph beside them as the emphasis attenuator rather than a level.

This is a second off-by-one next to the one fixed in 8104740, which corrected the crate's own doc comment from eleven legs to twelve and added a paragraph explaining why the array holds eleven while the mask is twelve bits wide. That commit deliberately did not widen its scope to this line.

What would close it

The word, and a check that the sentence still matches LEG_NAMES and leg_mask if one is cheap. The passing test the_dac_legs_speak_the_transcribed_table already asserts exactly one bit of a twelve-bit mask conducts at every half-step, so the numbering is pinned in the tests; only the prose is adrift.

Found 2026-09-20 while auditing the documents against the netlist.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions