Repository navigation
fix(client): retain one-start mailbox grant for persistent launch admission - #5474
Merged
Merged
Conversation
Casey-allard
added a commit
to Casey-allard/mvm
that referenced
this pull request
Nov 13, 2026
Join upstream c03a7c5 after tinylabscom#5474 merged. Production source is byte-identical to 9b02898; the sole net delta adopts the isolated 60000 ms signed-retention ceiling test while preserving backend refusal, restart and original ownership regressions. Independent code, Rust and security review passed. Targeted execution on the resulting tree remains pending; earlier source-bound results retain their original identities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream-owned continuation of fork PR #5336, preserving Casey-allard’s original implementation and test commits (original
18b58e1ad2, fork head9105b02b42) as ancestors. The original fork cannot be pushed with the available upstream credentials. This branch merges currentmainwithout conflicts and updates the two regression test calls to the now-three-argumentmailbox_grant::resolve(..., None)for requests without a workload IR.The behavioral change remains the original narrow fix: pass a persistent launch request’s mailbox grant through canonical start admission for that invocation; ordinary later starts do not inherit it from the stored machine definition. The mock backend test must refuse unsupported mailbox access before boot, and the ordinary restart test must have no mailbox authority. No journal/wire change, mailbox-service completion, or native lifecycle claim.
Validation:
cargo fmt --all -- --check,git diff --checkand staged whitespace check passed. The current headd0a6543d7f8f92caed1803a64734bcb8be60b7d4also supplies signed, host-ceiling-bounded retention in the mock request: otherwise newer production admission correctly refuses before the intended backend-capability check. Both focusedcargo test --locked -p mvm-client --features test-support --libregressions (persistent_request_mailbox_reaches_canonical_backend_admissionandpersistent_definition_restart_does_not_inherit_request_mailbox) passed locally; hosted PR and merge-queue checks are still required on these exact bytes. Historical Linux/native evidence belongs to #5336 at its named revision; the known original-child cleanup defect remains open. Credit and full provenance: #5336.Do not close #5336 as superseded until this replacement is validated and queued.