Repository navigation
refactor: delete pure-forwarding modules, callers use the owning crate (#4839) - #5433
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes 12 files that held only
pub useforwarding and points every caller at the owning crate. Net code lines are negative; check-rust-footprint measures 966076 on this tree merged with latest main (ceiling 966100).Removed:
commands/vm/{host_signer,audit_chain,plan_persist}.rs,commands/shared/vsock.rs(callers usemvm_client::host_keypair,mvm_client::audit::chain::*,mvm_client::guest,mvm_client::readiness)vsock_transport.rs(callers usemvm_vmm::vsock_transport),storage/volume/{backend,contract,local}.rs(re-exported fromstorage::volumestraight from mvm-contract; item paths unchanged)test_support.rsdecorator/mod.rscompatibility facade (no consumer in this workspace or in the sibling mvmd, mvm-studio, mvmforge, mvm-assurance checkouts)Kept on purpose: mvm-client forwarding modules (embedder surface, and the CLI-through-client ratchet), root facade, mvmd_iface re-exports (used by mvm-hostd), module-root files that declare
mod, and thepub use self::x::*flattening globs. No glob gate was added.Checked: fmt, workspace clippy (pre-commit),
just check::gated, nextest of mvm-sdk, mvm-build and mvm-runtime, xtask check-rust-footprint, check-file-size, check-doc-claims, check-doc-links, check-spec-hygiene, check-claim-catalog, check-witness-citations, check-cli-runtime-surface, check-no-orchestration-server.sh.Refs #4839 (the umbrella stays open; this PR does not close it).