Repository navigation
feat(cli): compose options from flags, environment, and files - #5412
Merged
Merged
Conversation
auser
marked this pull request as ready for review
November 13, 2026 03:31
auser
enabled auto-merge
November 13, 2026 03:35
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 13, 2026
auser
enabled auto-merge
November 13, 2026 04:31
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 13, 2026
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in, repeatable
--config-file PATHto compose CLI options from explicit flags, ordered TOML/JSON files, and command-scoped environment variables. Scalars resolve explicit > last file > environment; repeatables append environment, files in order, then explicit values. Relative and absolute config paths are supported; files cannot select a command.What changed
[global]and[commands.machine.run]syntax and the behavior of booleans, counts, aliases, and empty lists. Add parser, CLI dry-run, and refusal regressions for precedence, multiple files, guest environment filtering, and host CPU ceilings.Validation
cargo test -p xtask,cargo clippy --workspace -- -D warnings,cargo check --workspace, formatting, and the new hermetic BDD scenario. The footprint check passes on this rebased branch.cargo run -p xtask -- check-all(84 gates) on the rebased branch. CI remains the final review gate.cargo test --workspacedid not complete green locally: runs encountered a long macOS temporary socket path, intermittent unrelated agent timing/socket tests, and a workspace-only doctest failure (the doctest passed alone). Fulljust bdd::runtimed out; the new scenario passed alone. No live backend witness was run.Integration
This is independent of draft PR #5326; no changes were made to that branch. Review can proceed now; do not merge until its current work settles, then reconcile the footprint ratchet against the combined tree and validate before landing. A passing CI run or review alone is not authorization to merge.