Repository navigation
Conversation
…nder the footprint ceiling check-rust-footprint failed on main after the HVF pid-marker change: 966013 SLOC against a 966000 ceiling, which reds Invariant on every PR. The ceiling stays where it is. compose_runtime_layers (mvm-build) and EgressGate::decide_addr (mvm-vmm) are public, have no caller, test or reference anywhere in the tree or in any open PR branch, and are thin wrappers over helpers that remain (compose_authored_candidate, decide_addr_for_proto). Removing them takes the measured total to 965998.
Collaborator
Author
|
Superseded by #5373, which brought main under the footprint ceiling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red: check-rust-footprint reports 966013 SLOC against the 966000 ceiling after #5365, so Invariant fails on every PR, including the rustix security fix #5371 that the Security run needs.
The ceiling is unchanged. This deletes two public functions that nothing calls:
Checked: a search of every Rust source for each name finds only its definition, and none of the open PR branches (including the pack-composition ones) uses either. cargo clippy --all-targets -D warnings on mvm-build and mvm-vmm is clean, and cargo run -p xtask -- check-rust-footprint now passes at 965998 SLOC.
Margin is 2 lines, so the next change that adds code will need to delete some too. Related: #5121.