Skip to content

Bind local project policy launches to a committed generation #5391

Open

Description

@auser

Parent

#5386; aligned with #5097 and proposed ADR-111. First production slice for local project mvm.toml workloads; Firecracker is the first target, HVF and every other backend remain tracked by the parent and must not be treated as complete here.

Outcome

Once a local project opts into atomic apply, editing mvm.toml or a contributing policy file changes only staged inputs. Launch and restore must consume the same validated committed policy generation as the host-interface admission owner, bound by an exact source closure and effective policy digest. An unsupported source/backend refuses the atomic policy path rather than reading mutable bytes as if committed. Existing ordinary runs keep their documented behavior until migration is explicitly activated; do not claim they are atomically updated.

Acceptance

  • Decide and version the committed source closure (project manifest, included profiles/groups, relevant defaults) without duplicating policy composition; pin exact bytes/digests, source identity, effective policy, and generation.
  • Wire the real local project launch and restore caller to this committed generation and signed plan's existing policy identity; changes to staged files alone cannot widen an opted-in run.
  • Serialize committed-generation reads with apply preparation and launch. Fail closed on missing/corrupt committed state or an unknown source; no fallback to raw authored files after activation.
  • Tests for unchanged default local UX, staged edit ignored after activation, corrupt/tampered source, missing generation, concurrent launch/read/apply, and evidence of the exact admitted policy. Keep platform assumptions explicit.
  • Update matching user docs and record exact scoped/required validation in PR. No policy apply success, live rollover, or all-backend claim from this slice alone.

Ownership

Reuse mvm-client::policy_profiles composition, mvm-hostd::plan_admission/HostInterface authority, and the AssetKind::Policy identity already carried by local admission. Do not add a second policy gate or a passive generation type with no production caller.

Activity

  1. auser commented on Nov 12, 2026

    @auser
    CollaboratorAuthor

    Draft precursor PR #5440 is open from commit 611e09a6e5d094cff1ad3ec80dd6cce8d550b9de on feat/5391-policy-launch-snapshot (rebased before publication onto main at 615eb5e150). This is not completion of #5391.

    The change keeps the project's parsed manifest stable for routes, approval and secret declarations within a launch, including an absent source. Policy file validation uses the root bytes it classified. During one resolution, the policy walker refuses conflicting reads of the same profile/group or a named lookup switching identity, including an excluded group and late built-in shadowing. Proposed ADR-111 records the approved separate, automatically managed local mvm-hostd lifecycle coordinator, but no such owner is shipped.

    Post-rebase validation: focused route (6/6), secret (7/7), policy (22/22), resolver (36/36), isolated HVF restore and isolated guest-runtime concurrency tests passed. cargo clippy --workspace -- -D warnings, cargo check --workspace, just check::gated, cargo fmt --all -- --check and relevant xtask claim/doc checks passed. Two full TMPDIR=/tmp cargo test --workspace attempts failed in different unchanged parallel tests, each passing alone; the draft PR states this. The earlier full workspace pass was on the pre-rebase base and is not credited to this commit. No live Firecracker/HVF/all-backend cutover witness ran.

    Still required: immutable complete parsed source closure and durable committed generation under one resident owner; launch/restore reads of that generation; effect fencing, single-owner transfer and crash recovery; then live backend witnesses. Every acceptance checkbox remains open; no policy apply or rollover capability has shipped. Keep PR #5440 draft until its actual precursor scope and validation are reviewed; do not use it to close this issue.

  2. auser commented on Nov 13, 2026

    @auser
    CollaboratorAuthor

    Closing draft #5440 as an unfinished launch-source consistency precursor, not completion of committed-generation policy admission. Exact source-closure/digest/generation binding, serialized apply versus launch/restore, fail-closed missing/corrupt state, real caller integration and native tests remain open under this issue and #5392–#5394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions