Sync main-alt with upstream Parca - #2
Open
alexon1234 wants to merge 46 commits into
Open
Conversation
* GPU tooltip improvement * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Signed-off-by: Stefan Büringer buringerst@vmware.com Signed-off-by: Stefan Büringer buringerst@vmware.com
* Nuqs state updates pushed to history when chosen * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ev#6370) * External sumby value handled properly in the query state * Linter fix
…v#6374) * Using nuqs default options to enforce history behaviour * [pre-commit.ci lite] apply automatic fixes * touch * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…arca-dev#6376) ValidatePprofProfile runs on the WriteRaw ingest path, so it sees attacker-influenced pprof bytes. Two crashes are reachable there. First, period_type is an optional field and comes across as a nil *ValueType when omitted. Every other pointer in the validator is nil-checked, but the period_type branch dereferences p.PeriodType directly, so a profile that simply leaves it out panics inside the validator. Guard it like the rest. Second, the string-table index checks use > len(StringTable). String indices are 0-based, so the only valid values are 0..len-1 and an index equal to len passes the check but is one past the end. Downstream code (MetaFromPprof, LabelsFromSample) then indexes it and panics. Switch the eleven 0-based string-index checks to >=. The 1-based id checks (mapping/function/location) are left as > since len is a valid id there. Adds a table-driven test covering an omitted period_type and an index equal to the string-table length for both the sample-type and period-type paths. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
…ca-dev#6378) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…arca-dev#6358) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….7 [security] (parca-dev#6379) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…y] (parca-dev#6382) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ty] (parca-dev#6380) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rca-dev#6381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rity] (parca-dev#6383) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…urity] (parca-dev#6384) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….2 [security] (parca-dev#6386) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…curity] (parca-dev#6385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…curity] (parca-dev#6388) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…y] (parca-dev#6390) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ev#6394) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…arca-dev#6395) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ev#6396) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ev#6397) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…arca-dev#6399) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….4 [security] (parca-dev#6398) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…curity] (parca-dev#6400) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The merge is intentionally non-rebasing so the fork-only commits remain identifiable.