Bump vulnerable dependencies flagged by Dependabot - #415
Conversation
golang.org/x/net to 0.55.0 in the root module, and golang.org/x/crypto, golang.org/x/net and github.com/go-git/go-git/v5 in the desktop module. Bumping go-git to 5.19.2 pulled x/crypto to 0.53.0 and x/net to 0.56.0 through minimum version selection, both above the requested floor. react-router and vite bumped directly in desktop/frontend. brace-expansion, js-yaml, linkify-it, markdown-it and undici are transitive and needed overrides in package.json. brace-expansion is pinned to 5.0.9 rather than the requested 5.0.7: two further high-severity advisories (GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895) affect versions below 5.0.9 and 5.0.7 does not clear them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This reconciles the 12 open Dependabot PRs against the versions this PR actually lands. Versions come from
#397 is the one to keep open. This PR moves react-router from 7.15.1 to 7.18.2 in #395 needs a note. This PR adds an The 11 SUPERSEDED Dependabot PRs get closed with a comment naming this PR and the version it lands. #397 stays open. |
Closes #414
Bumps the packages Dependabot flagged across the three manifests in this repo.
Go —
go.modgolang.org/x/netmoved from 0.53.0 to 0.55.0, clearing GHSA-5cv4-jp36-h3mw.Go —
desktop/go.modgithub.com/go-git/go-git/v5moved from 5.19.1 to 5.19.2, clearingGHSA-hc8v-wwc9-vgxm and GHSA-qgq7-7hm3-q39j.
golang.org/x/cryptowas requested at 0.52.0 andgolang.org/x/netat0.55.0, but go-git 5.19.2 itself requires
golang.org/x/crypto0.53.0 andgolang.org/x/net0.56.0. Go's minimum version selection resolved both tothose higher versions. Both still land above the requested floor and clear
every advisory against them.
npm —
desktop/frontend/package-lock.jsonreact-routerandviteare direct dependencies, bumped to 7.18.2 and8.0.16. Bumping vite also pulled
postcssto a clean version and dropped avulnerable
nanoidtransitively — neither needed a manual change.brace-expansion,js-yaml,linkify-it,markdown-itandundiciaretransitive, pulled in by eslint, tiptap-markdown and jsdom. None of their
parents offer a fixed version directly, so they're pinned through
overridesinpackage.json:js-yamlto 4.3.1linkify-itto 5.0.2markdown-itto 14.2.0undicito 7.29.0brace-expansionto 5.0.9, not the requested 5.0.75.0.7 clears GHSA-3jxr-9vmj-r5cp, the advisory this bump was filed against.
It doesn't clear two further high-severity advisories against
brace-expansion, GHSA-mh99-v99m-4gvg (fixed in 5.0.8) and
GHSA-rgw5-rvv9-x895 (fixed in 5.0.9).
npm audit --audit-level=highstillflagged brace-expansion as high at 5.0.7, so it's pinned to 5.0.9 instead.
npm audit --audit-level=highnow reports zero vulnerabilities.Verification
Baseline (before any change), using the commands
.github/workflows/ci.ymlruns:
go build ./...,go vet ./...,go test ./...: all passdesktop/frontend:npm ci,npm run lint,npm run test,npm run build,npm run build:web: all pass (56 test files, 442 tests,15 smoke suites)
Same commands after the bump: same results, nothing regressed.
desktop/go.modisn't built in CI (noted inci.ymlas out of scope untilthe desktop app is a released artifact). Checked anyway:
go vet ./...andgo test ./...pass, matching baseline.go build ./...fails baselineand after the bump identically, in
desktop/build/iosonly(
runtime.main_main·f: function main is undeclared in the main package) —pre-existing, unrelated to this change.
govulncheck ./...against both Go modules shows no remaining module-levelfinding for
golang.org/x/net,golang.org/x/cryptoorgithub.com/go-git/go-git/v5. What's left in both modules is entirely Gostandard library findings tied to the go1.26 toolchain itself, out of scope
here.