docs: add phased frontend architecture modernization plan - #369
Open
mrgeoffrich wants to merge 1 commit into
Open
docs: add phased frontend architecture modernization plan#369mrgeoffrich wants to merge 1 commit into
mrgeoffrich wants to merge 1 commit into
Conversation
Research the React frontend (desktop/frontend/src) and lay out a multi-phase plan covering modern React practices, cross-cutting concerns, and decomposition of the largest files. Findings captured: App.tsx is a 1590-line god component (23 useState / 16 useEffect / 48 useCallback); polling, localStorage, and optimistic-update patterns are hand-rolled in ~25 places; no state library, no Context, no test framework (16 ad-hoc smoke tests not run in CI); api.ts (1485) and api.http.ts (3289) duplicate ~48 DTOs with silent web-mode drift risk. Plan phases: (0) test+lint foundation, (1) cross-cutting hooks, (2) tame the api seam, (3) data/state layer to slim App, (4) decompose big views, (5) consistency+hardening. Includes a 17-PR ticket breakdown. https://claude.ai/code/session_01X891F89wtXc1bQo4iHXbwE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research the React frontend (desktop/frontend/src) and lay out a multi-phase
plan covering modern React practices, cross-cutting concerns, and decomposition
of the largest files.
Findings captured: App.tsx is a 1590-line god component (23 useState / 16
useEffect / 48 useCallback); polling, localStorage, and optimistic-update
patterns are hand-rolled in ~25 places; no state library, no Context, no
test framework (16 ad-hoc smoke tests not run in CI); api.ts (1485) and
api.http.ts (3289) duplicate ~48 DTOs with silent web-mode drift risk.
Plan phases: (0) test+lint foundation, (1) cross-cutting hooks, (2) tame the
api seam, (3) data/state layer to slim App, (4) decompose big views, (5)
consistency+hardening. Includes a 17-PR ticket breakdown.
https://claude.ai/code/session_01X891F89wtXc1bQo4iHXbwE