Skip to content

fix: mbz check range for sev-snp report parsing#68

Merged
sachaservan merged 1 commit intomainfrom
fix/validation
Mar 24, 2026
Merged

fix: mbz check range for sev-snp report parsing#68
sachaservan merged 1 commit intomainfrom
fix/validation

Conversation

@sachaservan
Copy link
Copy Markdown
Member

@sachaservan sachaservan commented Mar 24, 2026

Summary by cubic

Fixes SEV-SNP report parsing by making the MBZ range version-aware. v5+ skips launch_mit_vector and current_mit_vector, while v2/v3 still enforce MBZ from 0x1F8, so valid v5+ reports are accepted.

  • Bug Fixes
    • Set MBZ start to 0x1F8 for versions <5 and 0x208 for v5+, checking only reserved bytes before the signature.
    • Added inline comments documenting v5+ field layout and the reserved range.

Written for commit 4303518. Summary will update on new commits.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/tinfoil/attestation/abi_sev.py">

<violation number="1" location="src/tinfoil/attestation/abi_sev.py:330">
P2: Make this MBZ range version-aware. The new unconditional `0x208` start skips reserved-byte validation for v2/v3 reports.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@sachaservan sachaservan merged commit 014ff9a into main Mar 24, 2026
1 check passed
@sachaservan sachaservan deleted the fix/validation branch March 24, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant