fix: mbz check range for sev-snp report parsing#68
Merged
sachaservan merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/tinfoil/attestation/abi_sev.py">
<violation number="1" location="src/tinfoil/attestation/abi_sev.py:330">
P2: Make this MBZ range version-aware. The new unconditional `0x208` start skips reserved-byte validation for v2/v3 reports.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
e37cdab to
4303518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes SEV-SNP report parsing by making the MBZ range version-aware. v5+ skips
launch_mit_vectorandcurrent_mit_vector, while v2/v3 still enforce MBZ from 0x1F8, so valid v5+ reports are accepted.Written for commit 4303518. Summary will update on new commits.