Merged
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/test_verification_failures_integration.py">
<violation number="1" location="tests/test_verification_failures_integration.py:30">
P2: Validate that `TINFOIL_TEST_CORRECT_REPO` and `TINFOIL_TEST_WRONG_REPO` are distinct; otherwise misconfigured CI/dev envs can make mismatch tests fail for the wrong reason.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Removed hardcoded references to
gpt-oss-120b-freeand made integration tests require explicit env vars. This decouples tests from a single model and prevents misconfigured runs.Refactors
tests/test_tdx_attestation_flow.py: requireTINFOIL_TEST_REPOandTINFOIL_TEST_ENCLAVE; skip module if missing; updated examples to<org/repo>and<enclave-hostname>.tests/test_verification_failures_integration.py: requireTINFOIL_TEST_CORRECT_REPOandTINFOIL_TEST_WRONG_REPO; skip module if missing; generalized wrong-repo messaging.Migration
TINFOIL_TEST_REPOandTINFOIL_TEST_ENCLAVEfor the TDX flow test.TINFOIL_TEST_CORRECT_REPOandTINFOIL_TEST_WRONG_REPOfor the verification failures test.Written for commit 66c3cc3. Summary will update on new commits.