Skip to content

⚡ Bolt: Cache next_change_id in DocxXMLEditor#11

Open
timteh wants to merge 1 commit intomainfrom
bolt/docx-cache-optimization-17502207051207918516
Open

⚡ Bolt: Cache next_change_id in DocxXMLEditor#11
timteh wants to merge 1 commit intomainfrom
bolt/docx-cache-optimization-17502207051207918516

Conversation

@timteh
Copy link
Copy Markdown
Owner

@timteh timteh commented Feb 5, 2026

  • 💡 What: Cached the _next_change_id in DocxXMLEditor to avoid repeated DOM scans.
  • 🎯 Why: Batch insertions of tracked changes were quadratic O(N²) because each insertion triggered a full DOM scan to find the next ID.
  • 📊 Impact: Reduces complexity to O(N). Verified 16x speedup for 2000 insertions (6.6s -> 0.4s).
  • 🔬 Measurement: Benchmarked using a script inserting 2000 tracked changes. Checked that generated IDs remain unique.

PR created automatically by Jules for task 17502207051207918516 started by @timteh

- Initializes `_next_change_id_cache` in `__init__`
- Updates `_get_next_change_id` to use and update the cache instead of scanning DOM every time
- Reduces complexity of batch insertions from O(N^2) to O(N)

Co-authored-by: timteh <211128536+timteh@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant