Skip to content

Add branch specification and refresh submodule to latest master - #13

Open
timlaing wants to merge 3 commits into
mainfrom
update-submodules
Open

Add branch specification and refresh submodule to latest master#13
timlaing wants to merge 3 commits into
mainfrom
update-submodules

Conversation

@timlaing

@timlaing timlaing commented Jul 5, 2026

Copy link
Copy Markdown
Owner

This pull request updates the music-assistant-alexa-api/skill-api submodule to track the master branch and points it to a newer commit. These changes ensure that the submodule always references the latest code on the master branch, which helps keep dependencies up to date.

Submodule configuration updates:

  • .gitmodules: Added the branch = master setting to the music-assistant-alexa-api/skill-api submodule to ensure it tracks the latest changes from the master branch.

Submodule commit update:

timlaing and others added 2 commits July 5, 2026 14:12
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@timlaing
timlaing requested a review from Copilot July 5, 2026 13:17
@timlaing timlaing self-assigned this Jul 5, 2026
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1925a62a-8112-4f0c-af6c-be7bbcd49850

📥 Commits

Reviewing files that changed from the base of the PR and between b328fc0 and 608ee6c.

📒 Files selected for processing (1)
  • .gitmodules
🚧 Files skipped from review as they are similar to previous changes (1)
  • .gitmodules

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated a bundled submodule reference to a newer revision.
    • Added a branch setting for that submodule to align remote update behaviour with the expected upstream branch.

Walkthrough

The .gitmodules file now specifies branch = master for the skill-api submodule, and the submodule's pinned commit reference is updated to a newer commit hash.

Changes

Submodule configuration update

Layer / File(s) Summary
Branch tracking and pointer update
.gitmodules, music-assistant-alexa-api/skill-api
Adds a branch = master setting to the skill-api submodule entry and updates the submodule's commit reference to a new hash.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A branch now marked, “master” to trail,
A submodule hops down a fresher tail,
Hop, hop, commit updated with cheer,
A tiny change, but the path is clear! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the submodule branch setting and the refreshed submodule pointer.
Description check ✅ Passed The description accurately matches the submodule branch configuration change and commit update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-submodules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the repository’s submodule configuration so the music-assistant-alexa-api/skill-api submodule is configured to track the master branch, and refreshes the submodule pointer to a newer commit to pick up upstream changes.

Changes:

  • Add branch = master for the music-assistant-alexa-api/skill-api submodule in .gitmodules.
  • Update the music-assistant-alexa-api/skill-api submodule gitlink to a newer commit (as described in the PR metadata).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.gitmodules Configures the skill-api submodule to track master for --remote submodule updates.
music-assistant-alexa-api/skill-api Advances the submodule pointer to a newer upstream commit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .gitmodules
@alexvaltchev

Copy link
Copy Markdown

This PR is the correct fix for the widely-reported 404 on /alexa/intents (see #11, with multiple affected users). For context in case it helps prioritize:

The current add-on release (v1.0.3) pins skill-api at 82ad59c, which predates the /alexa/intents route, so current Music Assistant (whose Alexa provider calls GET /alexa/intents in _load_intents) always 404s. Bumping the submodule to 836b454 (as this PR does) pulls in app/alexa_api/alexa_routes.py, which serves that route — so this should resolve it without users having to downgrade their MA server.

The blocker right now looks to be the failing add-on build check (aarch64 build failing, amd64 cancelled). Is that failure related to the new submodule's changed layout / build steps (e.g. the Dockerfile COPY paths, which changed from skill-api/app/lambda/py to the newer app/ structure)? If the COPY paths need updating to match the refreshed submodule, that may be what's breaking the image build.

Happy to test a resulting build on HA OS (amd64) against MA 2.9.9 once the checks pass. Thanks for maintaining this!

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@timlaing

Copy link
Copy Markdown
Owner Author

This PR is the correct fix for the widely-reported 404 on /alexa/intents (see #11, with multiple affected users). For context in case it helps prioritize:

The current add-on release (v1.0.3) pins skill-api at 82ad59c, which predates the /alexa/intents route, so current Music Assistant (whose Alexa provider calls GET /alexa/intents in _load_intents) always 404s. Bumping the submodule to 836b454 (as this PR does) pulls in app/alexa_api/alexa_routes.py, which serves that route — so this should resolve it without users having to downgrade their MA server.

The blocker right now looks to be the failing add-on build check (aarch64 build failing, amd64 cancelled). Is that failure related to the new submodule's changed layout / build steps (e.g. the Dockerfile COPY paths, which changed from skill-api/app/lambda/py to the newer app/ structure)? If the COPY paths need updating to match the refreshed submodule, that may be what's breaking the image build.

Happy to test a resulting build on HA OS (amd64) against MA 2.9.9 once the checks pass. Thanks for maintaining this!

I am hoping to get a new release of this done in the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants