Add branch specification and refresh submodule to latest master - #13
Add branch specification and refresh submodule to latest master#13timlaing wants to merge 3 commits into
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesSubmodule configuration update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request updates the repository’s submodule configuration so the music-assistant-alexa-api/skill-api submodule is configured to track the master branch, and refreshes the submodule pointer to a newer commit to pick up upstream changes.
Changes:
- Add
branch = masterfor themusic-assistant-alexa-api/skill-apisubmodule in.gitmodules. - Update the
music-assistant-alexa-api/skill-apisubmodule gitlink to a newer commit (as described in the PR metadata).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitmodules |
Configures the skill-api submodule to track master for --remote submodule updates. |
music-assistant-alexa-api/skill-api |
Advances the submodule pointer to a newer upstream commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR is the correct fix for the widely-reported 404 on The current add-on release (v1.0.3) pins The blocker right now looks to be the failing add-on build check (aarch64 build failing, amd64 cancelled). Is that failure related to the new submodule's changed layout / build steps (e.g. the Dockerfile Happy to test a resulting build on HA OS (amd64) against MA 2.9.9 once the checks pass. Thanks for maintaining this! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
I am hoping to get a new release of this done in the next week. |
This pull request updates the
music-assistant-alexa-api/skill-apisubmodule to track themasterbranch and points it to a newer commit. These changes ensure that the submodule always references the latest code on themasterbranch, which helps keep dependencies up to date.Submodule configuration updates:
.gitmodules: Added thebranch = mastersetting to themusic-assistant-alexa-api/skill-apisubmodule to ensure it tracks the latest changes from themasterbranch.Submodule commit update:
music-assistant-alexa-api/skill-api: Updated the submodule pointer to commit836b454, pulling in the latest changes from the submodule repository.