Repository navigation
Conversation
one2123
force-pushed
the
feat/sftp-file-management
branch
from
October 8, 2026 13:10
22f7789 to
5672d22
Compare
Author
|
Closing this PR in favor of a replacement PR created from a clean recovery branch. The original branch was affected by a rebase issue, so I recovered and verified the SFTP implementation and pushed it to a new branch to provide a cleaner diff against the latest upstream baseline. The replacement PR contains the SFTP file-management, remote editing, transfer progress, and cancellation changes. Please continue the review on the replacement PR: #157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
SFTP file management in the GUI.
Transfer progress and cancellation.
SFTP resource management.
Remote file editor support.
Implementation
Core SFTP
crates/omnyssh-core/src/ssh/sftp.rsAdded and extended SFTP command handling for:
DownloadUploadDownloadDirUploadDirCancelTransferDeleteDeleteWithProgressMkDirRenameReadPreviewReadFileWriteFileMajor implementation areas include:
do_download()do_upload()do_download_dir()do_upload_dir()do_read_preview()do_read_file()do_write_file()scan_remote_tree()delete_remote_tree()Also added transfer cancellation tracking and explicit SFTP file-handle cleanup.
GUI SFTP commands
crates/omnyssh-gui/src/commands/sftp.rsSFTP state/store
crates/omnyssh-gui/ui/src/lib/stores/sftp.tscrates/omnyssh-gui/ui/src/lib/stores/sftp.test.tsSFTP view
crates/omnyssh-gui/ui/src/lib/screens/SftpView.svelteTauri bindings
crates/omnyssh-gui/ui/src/lib/bindings.tsCore events
crates/omnyssh-core/src/event.rsTest plan
cargo check --workspacecargo check -p omnyssh-corecargo build -p omnyssh-guicargo test --workspaceRelated issue
Closes #91