Keep deleted questions, people and items out of a new packing list - #327
Merged
Merged
Conversation
Deleting a question, a traveller or a question-set item leaves a tombstone in the question set — the entity stays in the document carrying a `deletedAt` so the deletion reaches the pod and wins the per-entity merge. The create-a-list page read the stored document straight, so every deleted question came back on it, with nothing under it whenever its options had been removed first (an option is deleted outright, so an emptied-then- deleted question has none left to show). Deleted travellers were offered and pre-selected too, and deleted items were generated onto the new list. Add `activeQuestionSet`, the tombstone-free view of a set, and read through it wherever the create flow shows or generates from the question set — including "update from questions", which was re-adding deleted items as additions. Writes still use the stored set: saving the filtered one back would purge the tombstones and undo every deletion on the next sync. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015sWWKuzqv6fjBejJNniGCk
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a question, a traveller or a question-set item leaves a tombstone
in the question set — the entity stays in the document carrying a
deletedAtso the deletion reaches the pod and wins the per-entity merge.The create-a-list page read the stored document straight, so every deleted
question came back on it, with nothing under it whenever its options had
been removed first (an option is deleted outright, so an emptied-then-
deleted question has none left to show). Deleted travellers were offered
and pre-selected too, and deleted items were generated onto the new list.
Add
activeQuestionSet, the tombstone-free view of a set, and read throughit wherever the create flow shows or generates from the question set —
including "update from questions", which was re-adding deleted items as
additions. Writes still use the stored set: saving the filtered one back
would purge the tombstones and undo every deletion on the next sync.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015sWWKuzqv6fjBejJNniGCk