Skip to content

Extra pumpingtest examples#73

Merged
mbakker7 merged 8 commits intotimflow-org:devfrom
HsHeesen:dev
Mar 20, 2026
Merged

Extra pumpingtest examples#73
mbakker7 merged 8 commits intotimflow-org:devfrom
HsHeesen:dev

Conversation

@HsHeesen
Copy link

No description provided.

@mbakker7 mbakker7 mentioned this pull request Mar 18, 2026
@mbakker7
Copy link
Contributor

Thanks. This is quite nice. A few changes before this can be merged.

  1. When a timflow model is solved, the optimal parameters and rmse are printed to the screen. Do this consistent for all notebooks. For example, confined 1 is correct, but confined 4 is not. Use something like
display(cal.parameters.loc[:, ["optimal"]])
print(f"RMSE: {cal.rmse():.3f} m")
  1. At the end of most notebooks, a table is shown where the timflow estimated parameters are compared in a table to estimates from other software. This is done with a fancy pandas table. Can you hide the table (hide-input)?
  2. Something doesn't go quite right with slugtest 4 on the readthedocs of the PR. Check it out:
    https://timflow--73.org.readthedocs.build/en/73/transient/04pumpingtests/index.html

@mbakker7
Copy link
Contributor

Looks nice. Last thing: In the ReadTheDocs, the list on the left side shows the Moensch example as number 2 and there is not number 1 unconfined: https://timflow--73.org.readthedocs.build/en/73/transient/04pumpingtests/index.html. I guess just changing the title of the Notebook will fix that.

@mbakker7
Copy link
Contributor

Looks great. Thanks for your PR!

@mbakker7 mbakker7 merged commit 59dec0d into timflow-org:dev Mar 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants