Repository navigation
强化 Unity 文本定位、Addressables 与 TMP 字体工作流 - #5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8303c8168
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .replace("\r\n", "\n") | ||
| .replace("\r", "\n") | ||
| .replace("\n", "\\n") |
There was a problem hiding this comment.
Preserve CR bytes in DMSL source rows
When a DMSL operand contains \r or CRLF line breaks, the extractor writes the source CSV with those bytes normalized to \n, but the writeback path later unflattens that cell as LF-only and compares it to original_utf8_sha256. That makes the freshly generated source CSV fail its own manifest validation for any row with CR/CRLF text, so those extracted rows cannot be dry-run or preserved successfully.
Useful? React with 👍 / 👎.
| raise SystemExit(f"input file not found: {source}") | ||
| if not game_root.is_dir(): | ||
| raise SystemExit(f"game root not found: {game_root}") | ||
| if out == target or inside(out, game_root) or inside(report_path, game_root): |
There was a problem hiding this comment.
Reject output paths that overwrite donor assets
If the donor bundle is outside the game root, --out can be set to the same path as --donor and --force will allow the build to proceed; the final os.replace(temp, out) then overwrites the donor input even though it is supposed to be a template for the candidate. This check should reject the donor path as well as the target path before any output conflict handling.
Useful? React with 👍 / 👎.
变更内容
--base-root顺序合成和重开验证。m_text、UI 标签字段和 Unity Localization StringTable。agents/openai.yaml。复盘根因
此前工作流存在三类主要盲区:
安全边界
catalog.hash,不修改bundleSize。用户影响
技能可以更完整地覆盖剧情、设置页和本地化表文本,并为 Addressables 黑屏与 TMP 错字映射提供可复用、可审计的诊断和修复路径。现有 AiNiee 翻译流程不变。
验证
quick_validate.py通过。py_compile与--help。git diff --cached --check通过;未包含游戏二进制、字体、项目报告、机器绝对路径或临时测试目录。