Repository navigation
Story 5.16: the config-key registry gains a parity guard and the template catches up - #353
Merged
Merged
Conversation
…fixed (story 5.16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #340.
tools/tests/test-config-registry: every key in any tool'sCONFIG_DEFAULTS,tanuki-config'sBUILTIN_DEFAULTS, or a CATALOG entry binding intodefaults.*— plus every template key — must have a row in the docs registry table; a missing row fails CI naming the key.drive_concurrencyrow backfilled at triage was wrong — the key reads from the scenarios-file"loop"block only (tools/tanuki-drive:1489-1492), neverconfig.json. Row removed; the preamble now states the loop-block namespace is outside this registry (AC3).contribute_backhad no row despite CATALOG bindingdefaults.contribute_back.{path,schema}— a genuine registry gap; row added (per-target only, both-or-neither, machine-wide copy ignored per contribute_back configuration is global/machine-wide; configuring it for a scratch target mutates shared state #241/F198).driven_env_passthrough: []andreach_min_turns: 5. Judgment recorded:drive_concurrencydeliberately NOT added (not a config.json key).policy_sourcelegitimately document chain keys with no default (the story question's answer).Acceptance criteria mapping
astfrom all five tools; failure names tool + keys.Review focus
docs/tanuki-spec.md— it now defines the enforced contract; disagree there, not in the test.contribute_backrow's phrasing againstspec-den-distill§2.docs/tanuki-spec.md(as did Story 5.14: tanuki-spec's paraphrase layer is archived behind pointers #351, merged) — no remaining overlap with open PRs except none known.Changed areas
tools/tests/test-config-registry(new),docs/tanuki-spec.md,templates/config.example.json.Test plan
New guard passes; full suite 80/80 locally.
🤖 Generated with Claude Code