Conversation
of searches altered types and assertions to suit the new url strategy added notes for albums.json on things im shakey on because json wont allow comments plodding away on albums.json apple music works now
implementation will need some refining
failing im sick of doing it though i shall ascond to watch family guy and play with my balls
tests have not been run yet just inching this forward
docs need to be rewritten
I altered how queue works, well chat did im not really sure if its better though
problem than a chat problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a central matchAlbums function that consumes a service name and its corresponding metadata
munite no longer fetches data on the fly, it allows it to be cached upstream