refactor(codegen): unify review follow-ups - #167
Merged
Merged
Conversation
zhen8838
commented
Sep 13, 2026
zhen8838
force-pushed
the
refactor/pr165-followups
branch
from
September 14, 2026 15:37
abe4761 to
af88450
Compare
zhen8838
force-pushed
the
refactor/pr165-followups
branch
from
September 15, 2026 06:10
ca932f2 to
ca65c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
CodegenContext, derive target-local emit contexts, and route common C++ plus CUDA-specific TIR traversal throughCppEmitterandCudaEmittervisitors.grid_xandblock_xlaunch convention as scalar signature parameters.Spread[V], rename analysis workservicetoother_ops, and render metadata directly in type-specific printer methods.Contract
compile()runs the default pass pipeline and then calls the lower-levelbuild()path for pass-prepared TIR.flopsandother_opsexpose independentlogical,total, and topology-orderedper_unitvalues while preserving dtype or operation-kind breakdowns.Nonefallback.Risk