Skip to content

feat: support criterion 0.8#284

Open
xu-cheng wants to merge 2 commits intotikv:masterfrom
xu-cheng:criterion-0.8
Open

feat: support criterion 0.8#284
xu-cheng wants to merge 2 commits intotikv:masterfrom
xu-cheng:criterion-0.8

Conversation

@xu-cheng
Copy link
Copy Markdown

@xu-cheng xu-cheng commented Dec 1, 2025

Update MSRV to 1.86 as it is required by criterion 0.8. Also fixed any clippy issues.

Replace #277.

Update MSRV to 1.86 as it is required by criterion 0.8.

Signed-off-by: Cheng Xu <git@xuc.me>
Signed-off-by: Cheng Xu <git@xuc.me>
@tillrohrmann
Copy link
Copy Markdown

I would love if we could get this merged. This will allow us to upgrade our criterion dependency to 0.8 :-)

@vtselfahel
Copy link
Copy Markdown

https://github.com/grafana/pprof-rs seems to be a maintained fork. It may be better to contribute there.

@korniltsev-grafanista
Copy link
Copy Markdown

https://github.com/grafana/pprof-rs seems to be a maintained fork. It may be better to contribute there.

This is a fork we created to address grafana's users problems(bugs, crashes, performance), it is not a general purpose continuation of the pprof-rs.
I would like to keep the number of patches in the fork to the minimum(especially those that do not fix bugs or improve performance). I hope to merge all of our patches to tikv once tikv start to respond. Grafana has no capacity to maintain this rust library as a general purpose continuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants