feat(test): Add static policy analysis tool for network policy validation #4411
+971
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This adds a static analysis tool that: - Extracts pod labels from rendered Deployments/DaemonSets/StatefulSets - Extracts policy selectors from v3.NetworkPolicy objects - Validates that policy selectors match actual pod labels - Reports mismatches that could cause traffic blocking issues The tool runs as part of render tests and validates: - Policy selectors match at least one pod in the same namespace - Egress destination selectors match pods in target namespaces - Ingress source selectors match pods in source namespaces Files: - pkg/render/testutils/policy_analysis.go: Extraction and validation utilities - pkg/render/policy_analysis_test.go: Main test that renders components and analyzes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a static analysis tool that validates network policy selectors match actual pod labels. This helps catch bugs like the PrometheusSelector issue (PR #4410) where policy selectors didn't match actual pod labels.
Type: New feature (test infrastructure)
Why this should be merged:
Testing:
go test -v -run TestPolicyAnalysis ./pkg/render/...Components affected:
The tool validates:
Release Note
For PR author
make gen-filesmake gen-versions