Fix weak password checks not running in scan mode#138
Open
tera-si wants to merge 1 commit into
Open
Conversation
|
Hello any update here seems important |
khenissimehdi
approved these changes
May 26, 2026
khenissimehdi
left a comment
khenissimehdi
left a comment
There was a problem hiding this comment.
Testing the added code on my side the checks are now running as they should be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After commit #110, the password list starts with an empty line. This causes the
while commonPass:check to be evaluated false, skipping the weak password loop in the automated scans.This fixes that by changing the while-loop to a for-loop.