Repository navigation
Remove extras - #405
Remove extras#405JLesDev wants to merge 27 commits into
Conversation
Tokio-rustls 0.26.4 Cache v4 Docker compose Docker compose Docker compose Docker compose Docker compose errors Docker compose errors Docker compose errors Docker compose errors Docker compose errors Docker compose errors Syntax fix Syntax fix Syntax fix Syntax fix Syntax fix cache v4 features changes Format Rust code using rustfmt features changes features changes features changes Format Rust code using rustfmt features changes Format Rust code using rustfmt features changes features changes features changes Format Rust code using rustfmt features changes features changes NOW CHANGING TOKIO RUSTLS VERSION TO 0.26.4 Pipeline fixed Macos-latest Remove docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose docker-compose mac os apple container mac os apple container mac os apple container resetting resetting resetting resetting resetting resetting resetting reset reset reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests reset with more tests Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Removing docker-compose.yml due to the new testing process Clean up Clean up Clean up Clean up Clean up Clean up Clean up Clean up Clean up Clean up Xtask layout Format Rust code using rustfmt Xtask layout Xtask layout Format Rust code using rustfmt Testing w/o Xtask Testing w/o Xtask Format Rust code using rustfmt Testing w/o Xtask Testing w/o Xtask Format Rust code using rustfmt Testing w/o Xtask Testing w/o Xtask Testing w/o Xtask Testing w/o Xtask Squashed Documentation Format Rust code using rustfmt Xtask Xtask Xtask Xtask Formatting xtask xtask xtask xtask Format Rust code using rustfmt xtask Format Rust code using rustfmt xtask Format Rust code using rustfmt xtask xtask xtask error fixing error fixing xtask xtask xtask xtask adding local fixing Using xtask Using xtask w/ local Using xtask w/ local Using xtask w/ local + test Using xtask w/ local + test Xtask work
steps for macos testing steps for macos testing 2019 only no run skip test macos skip test macos skip test macos skip test macos skip test macos skip test macos skip test macos macos test --lib + clippy macos test --lib + clippy
clippy --fix clippy --fix clippy --fix clippy --fix Cargo clippy
Cargo cached rerun No chocolatey No chocolatey + cargo cache
|
@esheppa — flagging you before we act on this one, since your "update certs generation" commit is on the branch. This PR (#405, opened 2026-01-13 by @JLesDev) is a large grab-bag. Reviewing it against the current 0.13 work, the substantive parts are either already covered or diverge from the direction we're maintaining:
Our inclination is to close it as superseded/divergent, but given your commit is on the branch I wanted your sign-off first. OK to close? If there's an isolated piece worth keeping (e.g. the certs-generation change), happy to pull it out as a focused PR instead. |
|
Thanks @MattJackson, good to close this. Regarding some of the changes, perhaps they can be considered separately, if you think it is worthwhile I'll create issues for some.
|
|
Thanks @esheppa, appreciate the quick sign-off — closing #405 on that basis. On the follow-ups: issues sound like a good way to keep those separate from this grab-bag, so please do open them if you have time — no pressure. On TLS specifically, a rustls-only move is a bigger call than I'd want to make lightly given downstream folks currently lean on the native-tls/openssl backends, but the trait-abstraction angle and the third-party-provider story both seem well worth talking through on their own thread rather than deciding here. The local-CI rationale for For anything worth salvaging from this branch (the certs-generation change included), a focused PR against current |
No description provided.