Skip to content

fix: allow query on columns with space in name - #296

Closed
Geo-W wants to merge 1 commit into
tiberius-rs:mainfrom
Geo-W:main
Closed

Geo-W wants to merge 1 commit into
tiberius-rs:mainfrom
Geo-W:main

Conversation

@Geo-W

@Geo-W Geo-W commented May 28, 2023

Copy link
Copy Markdown

As sql server allows empty space in column name, make it adaptable to columns with space in its name.

@tomhoule

Copy link
Copy Markdown
Contributor

This looks good. Do you think this would be straightforward to check in a test?

@Geo-W

Geo-W commented May 31, 2023

Copy link
Copy Markdown
Author

This looks good. Do you think this would be straightforward to check in a test?

Sure! Thank you very much~

@descawed

descawed commented Oct 8, 2023

Copy link
Copy Markdown
Contributor

I was bitten by this issue today when attempting to do a bulk insert to a table having columns with spaces in the name. Is this just waiting on a test to be merged? I can take a crack at it if @Geo-W isn't able to. The code should probably also be updated to handle the case where the column name contains the ] character, which would need to be escaped by doubling it.

@kivsiak

kivsiak commented Apr 21, 2025

Copy link
Copy Markdown

Is any progress here? I got same problem. The fix is trivial.

@MattJackson

Copy link
Copy Markdown
Contributor

Included in #441 — shipped in tiberius v0.13.0. Thanks for this! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants