-
-
Notifications
You must be signed in to change notification settings - Fork 391
feat(cli): add global option to disable automatic session title changes #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenbojian
wants to merge
3
commits into
tiann:main
Choose a base branch
from
chenbojian:feat/enable-auto-title-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,13 @@ | ||
| /** | ||
| * Codex-specific system prompt for local mode. | ||
| * | ||
| * This prompt instructs Codex to call the hapi__change_title function | ||
| * to set appropriate chat session titles. | ||
| */ | ||
|
|
||
| import { trimIdent } from '@/utils/trimIdent'; | ||
| import { shouldEnableAutoTitle } from '@/claude/utils/claudeSettings'; | ||
|
|
||
| /** | ||
| * Title instruction for Codex to call the hapi MCP tool. | ||
| * Note: Codex exposes MCP tools under the `functions.` namespace, | ||
| * so the tool is called as `functions.hapi__change_title`. | ||
| */ | ||
| export const TITLE_INSTRUCTION = trimIdent(` | ||
| export const TITLE_INSTRUCTION = shouldEnableAutoTitle() | ||
| ? trimIdent(` | ||
| ALWAYS when you start a new chat, call the title tool to set a concise task title. | ||
| Prefer calling functions.hapi__change_title. | ||
| If that exact tool name is unavailable, call an equivalent alias such as hapi__change_title, mcp__hapi__change_title, or hapi_change_title. | ||
| If the task focus changes significantly later, call the title tool again with a better title. | ||
| `); | ||
| `) | ||
| : ''; | ||
|
|
||
| /** | ||
| * The system prompt to inject via developer_instructions in local mode. | ||
| */ | ||
| export const codexSystemPrompt = TITLE_INSTRUCTION; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,10 @@ | ||
| /** | ||
| * OpenCode-specific system prompt for change_title tool. | ||
| * | ||
| * OpenCode exposes MCP tools with the naming pattern: <server-name>_<tool-name> | ||
| * The hapi MCP server exposes `change_title`, so it's called as `hapi_change_title`. | ||
| */ | ||
|
|
||
| import { trimIdent } from '@/utils/trimIdent'; | ||
| import { shouldEnableAutoTitle } from '@/claude/utils/claudeSettings'; | ||
|
|
||
| /** | ||
| * Title instruction for OpenCode to call the hapi MCP tool. | ||
| */ | ||
| export const TITLE_INSTRUCTION = trimIdent(` | ||
| export const TITLE_INSTRUCTION = shouldEnableAutoTitle() | ||
| ? trimIdent(` | ||
| ALWAYS when you start a new chat - you must call the tool "hapi_change_title" to set a chat title. When you think chat title is not relevant anymore - call the tool again to change it. When chat name is too generic and you have a chance to make it more specific - call the tool again to change it. This title is needed to easily find the chat in the future. Help human. | ||
| `); | ||
| `) | ||
| : ''; | ||
|
|
||
| /** | ||
| * The system prompt to inject for OpenCode sessions. | ||
| */ | ||
| export const opencodeSystemPrompt = TITLE_INSTRUCTION; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MAJOR]
enableAutoTitle=falseonly removes the tool from the HTTP MCP server here. Codex and OpenCode still go throughbuildHapiMcpBridge(...), andcli/src/codex/happyMcpStdioBridge.ts:72still unconditionally re-registerschange_title, so those modes can still see and call the title tool.Suggested fix:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in next commit