use frozen lock file#824
Open
aaspinwall wants to merge 1 commit into
Open
Conversation
Collaborator
|
Do we want to explicitly use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR removes
--no-frozen-lockfilefrom installs to make sure we use the audited packages at the top of the repoWhy?
This is a good security practice to avoid malicious packages being installed
Limitations and Notes
pnpm doesn't have a ci command. The npm equivalent in pnpm is pnpm install
--frozen-lockfile, which fails if the lockfile is out of sync — that's the safe behavior you want in a container/CI context.Applicable Issues
Closes #812
Screenshots