Vite v8 upgrade#292
Merged
Merged
Conversation
davinotdavid
approved these changes
Jun 16, 2026
davinotdavid
left a comment
davinotdavid
left a comment
Contributor
There was a problem hiding this comment.
LGTM after updating storybook with v10.4.6
| "prettier": "3.7.4", | ||
| "react": "19.2.4", | ||
| "storybook": "10.3.5", | ||
| "storybook": "10.4.5", |
Contributor
There was a problem hiding this comment.
NPM packages are updated like crazy recently 😅 There was another update to Storybook 6 hours ago that would be nice to add here:
https://github.com/storybookjs/storybook/releases/tag/v10.4.6
This apparently updates the esbuild version that has a current vulnerability.
Collaborator
Author
There was a problem hiding this comment.
Haha indeed! That was shortly after me creating that PR 😂 I'll update it, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
After having issues in #274 with peer dependencies, we decided to break that change down. This PR only does the Vite 8 upgrade and fixes 3 type mismatches reported when building the project. Also a minor Storybook update was applied.
Limitations and Notes
None
Applicable Issues
Related to #273