Pin NPM package dependecy versions + npm ci #290
Merged
Merged
Conversation
Contributor
Author
|
Thanks for the review @devmount as we chatted in Matrix, I believe it would be a better isolation if we merge this in then cut a patch version then merge your PR in and cut a patch version. What do you think? |
devmount
approved these changes
Jun 1, 2026
devmount
left a comment
Collaborator
There was a problem hiding this comment.
@davinotdavid Yes, let's do it like this! I take care of updating #274 when we tagged the next patch release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
package-lock.json:postcssfrom8.5.9to8.5.15due to security vulnerabilitiesnpm ciinstead ofnpm isince we have a checked-in package-lock.jsonWhy?
We should have stable package versions!
Applicable Issues
Closes #289