Fix all day events in week calendar view

[devmount]

What changed?

This change moves all day events from the calendar grid into a dedicated row on top of the grid.

Why?

The all day events currently span over all rows of a column hiding other events and breaking the UI.

Limitations and Notes

This is meant as a temporary fix until design for this all-day row is ready.

Applicable Issues

Fixes #1702
Fixes #1703

Screenshots

[rwood-moz]

This doesn't seem to be working for me, here's how I am trying it out:

• I created a bunch of all-day appointments in my google calendar that is already connected to my local appointment stack (one single all-day appointment, and some repeating all-day appointments too); I see the all-day appointments in my email's calendar outside of Appointment
• I pulled this branch locally and restarted my local stack with docker compose up --build
• I sign into my local Appointment, and in the calendar view the all-day appointments are not appearing at the top of the day columns or in the main view either; I do see my other appointments visible
• Even if I refresh the Appointment calendar view page using the refresh arrow, my all-day appointments still do not appear

Also quick question: If you have an all-day appointment will that remove that day from your availability / will that day appear as unavailable on the bookee / book appt share link page? I'm assuming it should? Thanks.

[devmount]

@rwood-moz Thanks for testing!

• I created a bunch of all-day appointments in my google calendar

Just to be sure: Did you make sure that those events actually have the busy/blocking status?

Also quick question: If you have an all-day appointment will that remove that day from your availability / will that day appear as unavailable on the bookee / book appt share link page? I'm assuming it should? Thanks.

They are supposed to be, yes. But there might be issues with that, I'll take a look at this.

[rwood-moz]

Thank you @devmount

Just to be sure: Did you make sure that those events actually have the busy/blocking status?

Ahh that was it, no I had the appointments marked as all day but by default they were marked as free time; I changed them to busy and they now appear in my Appointment calendar, nice!

Also quick question: If you have an all-day appointment will that remove that day from your availability / will that day appear as unavailable on the bookee / book appt share link page? I'm assuming it should? Thanks.

They are supposed to be, yes. But there might be issues with that, I'll take a look at this.

On my booking page the all-day appointments are making the time unavailable at least from the testing I did. I tested a single all-day appointment, an all-day appointment that repeats on one day each week, and an all-day appointment that repeats daily.

[devmount]

@rwood-moz Nice, thanks so much for re-testing this! So is it working as intended now or are there more issues on your end?

[rwood-moz]

@rwood-moz Nice, thanks so much for re-testing this! So is it working as intended now or are there more issues on your end?

Nope LGTM!