fix: move temporary test directories to os.tmpdir and ensure cleanup

[riddhima25bet10005-a11y]

Resolves #1. This PR moves the temporary directories created during unit tests from the project root to the system's temporary directory (os.tmpdir()) and ensures they are deleted after the test completes. This prevents root directory pollution.

[thunderavi]

Hi @riddhima25bet10005-a11y, thanks for the PR.

The PR is currently blocked because the GitHub Actions test jobs are failing in the npm run test:live:adapters step.

Failure shown in CI:

LIVE_ADAPTERS=true
FAIL tests/integration/liveAdapters.test.js
Cannot find module 'pg' from 'adapters/postgresql.js'
Cannot find module 'redis' from 'adapters/redis.js'
Cannot find module 'mongoose' from 'adapters/mongodb.js'

This looks like the live adapter test job is running without the optional provider packages installed. Please update the PR so the CI live-adapter path is handled correctly. A few possible fixes:

• install the required live adapter packages in the workflow before npm run test:live:adapters, or
• update the live adapter test setup so it skips providers whose optional packages are missing, or
• split mocked unit tests and credential-backed live adapter tests so the normal PR check does not fail on missing optional packages.

Please rerun the checks after updating the PR. Once CI is green, this should be much easier to review and merge.

[riddhima25bet10005-a11y]

Ok @thunderavi So should I wait?

[thunderavi]

Hi @riddhima25bet10005-a11y, no need to wait.

Please continue working on this PR and fix the failing CI issue. The problem is in the live adapter test step:

npm run test:live:adapters
Cannot find module 'pg'
Cannot find module 'redis'
Cannot find module 'mongoose'

Please update the PR so the workflow/test setup handles these optional dependencies correctly. You can either install the required packages in CI, skip live adapter tests when optional packages are missing, or separate live adapter tests from the normal PR checks.

After making the fix, push the changes to your branch and rerun the GitHub Actions checks. Once CI passes, I’ll review the PR again.

[riddhima25bet10005-a11y]

@thunderavi I think now its good to go.
Please review and merge it if its good.

[thunderavi]

Hi @riddhima25bet10005-a11y, I tested the PR locally.

Good news: the targeted plugin test passes, the full test suite passes locally, typecheck passes, and the updated plugin tests no longer create new tmp-easy-plugin-* folders in the project root.

However, the original issue is only partially fixed right now. The repository still has existing tracked temporary plugin folders/files, so they will remain in the repo even though new ones are no longer being created.

Please update the PR to remove the already-tracked temporary folders too:

git rm -r tmp-easy-plugin-*

Also, please add tsconfig.tsbuildinfo to .gitignore, because npm run typecheck still modifies that generated file locally.

After that, push the update to your PR branch. Then I can review again and move it closer to merge.

[thunderavi]

Hi @riddhima25bet10005-a11y, thanks for updating the PR. The tests are green now, and the temp-directory fix in tests/unit/plugins.test.js looks good.

Before I can approve, please keep this PR focused only on the temp-folder issue. Right now the PR also changes dependency lists, CI install behavior, TypeScript checking scope, knexfile.js, and a frontend hook. Those changes are outside the scope of this issue and should be moved to a separate PR.

Please remove the unrelated changes to:

• package.json
• package-lock.json
• tsconfig.json
• knexfile.js
• hooks/use-toast.ts
• .github/workflows/ci.yml
• broad optional dependency mocks in tests/setup.js, unless they are strictly required for this issue

This PR should mainly include:

• tests/unit/plugins.test.js using os.tmpdir() instead of process.cwd() for temporary plugin folders
• cleanup with fs.rmSync(...)
• .gitignore entries for tmp-easy-plugin-* folders if needed

Please move the TypeScript, dependency, and CI fixes to a separate PR. After the PR is focused, I can review it again for approval.

[thunderavi]

Thanks for the update. The temp directory fix looks good, but this PR still includes unrelated dependency, CI, TypeScript, knexfile, and frontend hook changes.

Please keep this PR focused only on the temporary plugin directory cleanup. Remove the unrelated changes and move them to a separate PR if needed.

[riddhima25bet10005-a11y]

Hi @thunderavi
I have done as you said.
Kindly review and confirm.

[thunderavi]

Hi @riddhima25bet10005-a11y, thanks for the update.

The current CI failure is from npm run typecheck, not from your temp-folder cleanup.

The failing errors are missing frontend/UI dependencies, for example:

Cannot find module 'next-themes'
Cannot find module '@radix-ui/react-*'
Cannot find module 'lucide-react'
Cannot find module 'class-variance-authority'
Cannot find module 'react-day-picker'

This is a separate existing frontend TypeScript issue tracked in #3.

Please keep this PR focused only on the temp-folder cleanup. Do not add broad frontend dependency changes or TypeScript config workarounds in this PR. I will handle the frontend typecheck issue separately.

For this PR, the important part is that the temporary plugin directories are created outside the repo root and cleaned up correctly.

[riddhima25bet10005-a11y]

@thunderavi Actually I am trying to get both CI checks and changes together.
I just saw that the checks failed.
I am working on it.

[thunderavi]

Hi @riddhima25bet10005-a11y, the latest CI failure is from npm run verify.

The dynamic dependency install is failing because of a React type peer dependency conflict:

@types/react-dom@19.2.3 requires @types/react@^19.2.0
but the project currently has @types/react@^18.2.37

Please do not try to fix the frontend dependency/typecheck problem in this PR. That is a separate issue (#3).

For this PR, please keep only the temp-directory cleanup changes for issue #1. Remove the frontend dependency, TypeScript, and CI workaround changes, and let this PR focus only on creating temporary plugin folders outside the repo root and cleaning them up correctly.

[riddhima25bet10005-a11y]

@thunderavi good to go

[riddhima25bet10005-a11y]

@thunderavi I am still working on it.
Give me some time.

[riddhima25bet10005-a11y]

@thunderavi is it good now?

[thunderavi]

@riddhima25bet10005-a11y No, this is not good yet.

The latest CI run is still failing in npm run test:coverage.

The failure is still because required optional/test dependencies are missing, including:

pg
@tensorflow/tfjs
openai
redis
sql.js
stripe
@sentry/node
nodemailer
@aws-sdk/client-s3

Also, the PR still changes verify-dependencies.js with a big dynamic dependency install workaround. I already asked you to remove that. Please do not keep adding broad CI/dependency workarounds to this PR.

This PR must stay focused only on the temporary plugin directory cleanup. Before asking again for review, please make sure:

• CI is passing
• verify-dependencies.js is not changed for unrelated dependency installs
• the PR only contains the temp-folder cleanup changes

Please fix these points first, then ask for review again.

[thunderavi]

Thanks @riddhima25bet10005-a11y. I rechecked the latest PR update.

Good news: the CI checks are passing, and I also tested locally:

npm run verify
npm run typecheck
npm test -- tests/unit/plugins.test.js --runInBand
npm run validate:production
npm run test:coverage

All of these passed.

However, I still cannot approve or merge this PR yet because it is not focused only on the temporary plugin directory cleanup issue.

The correct parts to keep are:

• .gitignore entries for tmp-easy-plugin-*, tmp-easy-plugin-reload-*, and tsconfig.tsbuildinfo
• tests/unit/plugins.test.js changes that use os.tmpdir() and clean up with fs.rmSync(...)
• removal of already-committed generated tmp-easy-plugin-* files and tsconfig.tsbuildinfo, if those files are still tracked in this PR

Please remove the unrelated changes from this PR, especially:

• tests/unit/branchEdges.test.js
• tests/unit/sqliteAdapter.test.js
• virtual mock changes in unrelated test files such as aiProviderManager, databaseAdapters, cloudStorageManager, emailService, mlEngine, observability, paymentProcessor, and similar files

Those changes are outside the scope of this issue and should be opened as a separate PR only if needed.

Once the PR only contains the temp-directory cleanup changes, I can review it again and merge it if everything is still passing.

[riddhima25bet10005-a11y]

@thunderavi I wrap it up by tomorrow.

[riddhima25bet10005-a11y]

@thunderavi Please check.

[thunderavi]

Hi @riddhima25bet10005-a11y, I reviewed the latest PR changes.

The main temp-directory idea is correct, but the PR still includes many unrelated changes. Please clean it up before asking for review again.

What you did correctly and should keep:

• tests/unit/plugins.test.js now creates temporary plugin folders using os.tmpdir() instead of the repository root.
• The temporary folders are cleaned up with fs.rmSync(..., { recursive: true, force: true }).
• Old tracked tmp-easy-plugin-* and tmp-easy-plugin-reload-* folders are removed.
• tsconfig.tsbuildinfo is removed from tracking.
• .gitignore includes entries for tmp-easy-plugin-*, tmp-easy-plugin-reload-*, and tsconfig.tsbuildinfo.

What you should not touch in this PR:

• Do not remove coverage/ from .gitignore.
• Do not add generated coverage/ files to the PR.
• Do not change package.json or package-lock.json for this issue.
• Do not remove dependencies such as pg, redis, openai, @tensorflow/tfjs, stripe, React/Radix UI packages, or other optional/test packages.
• Do not change tsconfig.json to exclude components, hooks, or lib. That hides TypeScript errors instead of fixing them.
• Do not change unrelated frontend files like components/ui/calendar.tsx or components/ui/resizable.tsx.
• Do not change unrelated backend/config files like knexfile.js.

Please update this PR so it only contains the temp plugin directory cleanup:

• keep the tests/unit/plugins.test.js cleanup changes
• keep removal of old tmp-easy-plugin-* folders
• keep tsconfig.tsbuildinfo ignored/removed
• keep coverage/ ignored
• remove all generated coverage/ files
• revert unrelated dependency, TypeScript, frontend, and knexfile changes

Right now Node 20, 22, and 24 are failing because the PR changes dependency files and removes packages that the test suite expects. After you make the PR focused and CI passes, I will review it again.

[riddhima25bet10005-a11y]

@thunderavi I can see all checks clear from the my side.
Kindly confirm.

[thunderavi]

Hi @riddhima25bet10005-a11y, your initial approach for moving temporary plugin folders to os.tmpdir() was good, and I appreciate the effort you have put into this PR.

Right now the PR still cannot be merged because CI is failing and the branch still contains unrelated changes. Please clean the PR so it only includes the temp-folder cleanup.

If you are stuck, please tell me clearly. I can guide you on exactly what to revert and what to keep. If you are not available to continue, that is okay too, but then I may need to fix this from the maintainer side so the issue can move forward.

Thank you for the effort so far.

[thunderavi]

Hi @riddhima25bet10005-a11y, thank you for your effort on this issue.

Your initial approach of moving the temporary plugin folders to os.tmpdir() was correct and helpful. Since the PR branch had become difficult to clean because of unrelated changes and failing CI, I created and merged a clean maintainer PR using the same core approach to fix the issue.

The issue is now resolved and closed through PR #25.

I really appreciate your work on identifying the right direction. Please feel free to pick another open issue and continue contributing.

[thunderavi]

Closing this PR because the issue has now been resolved through PR #25.

Thank you again for the initial approach and effort. Your idea of using os.tmpdir() was correct, but this branch had unrelated changes and failing CI, so we fixed it through a clean maintainer PR.

You are welcome to pick another open issue and continue contributing.