Skip to content

Rotate Fix #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thumun merged 2 commits into from
Dec 8, 2025
Merged

Rotate Fix #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e49fa0c
rotate fix
Dec 7, 2025
be5cf1b
Merge branch 'main' into neha/rotate-fix
Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/renderers/terrain-renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@ export class TerrainRenderer implements IRenderer {
return [0, 0, 0];
}

private DegToRad(degrees: number): number {
return degrees * (Math.PI / 180);
}

private createTransformMatrix(
translate: [number, number, number],
rotate: [number, number, number],
Expand All @@ -294,7 +298,7 @@ export class TerrainRenderer implements IRenderer {
const matrix = new Float32Array(16);

// Compute rotation matrices
const [rx, rz, ry] = rotate;
const [rx, rz, ry] = rotate.map((r) => this.DegToRad(r));
const cx = Math.cos(rx),
sx = Math.sin(rx);
const cy = Math.cos(ry),
Expand Down