[jochenkirstaetter]

Summary

Part 6 of 6 for Linux desktop support (stacked on #43 / linux-5-storage, #42 / linux-4-media, #41 / linux-3-input, and #38 / linux-2-basics).

Adds the Linux HTTPS client, self-updater (.AppImage and .deb), and setup uninstaller:

• Linux HTTPS Client (desktop/app/src/linux/http.rs):
  • HTTPS-only get, get_retrying, get_json, download, and download_to_file backed by curl (--proto =https --proto-redir =https) with wget (--https-only) fallback.
  • Enforces response byte limits and writes downloaded artifacts with O_NOFOLLOW and 0o600 permissions.
• Self-Updater (desktop/app/src/updater.rs):
  • Matches Linux .AppImage and .deb release assets (x86_64 and aarch64 / arm64) and verifies SHA-256 digests against SHA256SUMS.txt.
  • Stages downloads in an owner-only (0o700, UID-verified, non-symlink) cache directory (~/.cache/nectarlink/updates).
  • Supports atomic in-place .AppImage replacement and TOCTOU-hardened privileged .deb installation (PRIVILEGED_DEB_INSTALL_SCRIPT copies the package to root-owned 0700 /var/cache/nectarlink-update, re-verifies sha256sum -c as root, and runs dpkg -i).
• Setup & Uninstaller (desktop/app/src/setup.rs, desktop/app/i18n/):
  • Detects installed .deb (dpkg-query) and /opt/nectarlink installations, cleans up user autostart, shortcuts, send-to entries, and storage bookmarks, and runs elevated package/directory removal.
  • Includes de and zh_CN translations for the new Setup strings (Couldn't uninstall NectarLink: %1 and Uninstall stopped with code %1.).

Verification

• cargo fmt --all --check
• cargo xtask tokens --check
• cargo xtask strings --check
• cargo clippy --locked -p nectarlink-protocol -p nectarlink-core -p nectarlink-ffi -p nectarlink-cli -p xtask --all-targets -- -D warnings
• cargo test --locked -p nectarlink-protocol -p nectarlink-core -p nectarlink-ffi -p nectarlink-cli -p xtask
• cargo clippy --locked -p nectarlink-desktop -p nectarlink-vcam -p s1-qt-rust --all-targets -- -D warnings
• cargo test --locked -p nectarlink-desktop -p nectarlink-vcam (311 + 6 unit tests pass)
• pwsh ./scripts/check-headers.ps1 (456 files checked, 0 problems)

[thtbee]

Thanks for opening this. Notes for this part are on #38 (comment). The .deb update path is careful (the hash is checked again as root on a root-owned copy), nice. Small things: pkexec sh -c makes the prompt name sh; a tarball install only opens the browser; and reqwest with rustls is already in the dependency tree, which would remove the curl/wget dependency in linux/http.rs.

[jochenkirstaetter]

Updated with linux-5-storage and integrated @thtbee's Part 6 review fixes from linux-review-fixes (e58ee10 — HTTP response line bounds & preserved 120s idle read timeout, plus hardened .deb/.tar.gz setup and update flows), along with #[cfg] platform coverage in setup.rs and updater.rs for macOS CI. Huge thanks @thtbee for the collaborative effort!

[jochenkirstaetter]

Hi @thtbee

The failing CI for macOS has been noted, going to fix it.

Cheers

[thtbee]

I pushed one small fix on top (fdef5c2), since it was quicker than describing it. With setup::install and setup::remove moved to cfg(not(target_os = "linux")), macOS compiled the NSIS installer path (/S /PROGRESS, uninstall.exe); they're Windows-only again, and macOS has its own (no installer to run; removing clears this user's data). The Linux install no longer passes those switches to a file that's neither a .deb nor a tarball. And current_euid() read the owner of /proc/self, which doesn't exist on macOS and so came back as root; it uses libc::geteuid() now. Windows clippy is clean; CI will cover Linux and macOS. Thanks again for taking in all the review fixes so quickly.

[thtbee]

Sorry, my earlier commit broke the macOS clippy job: the crate denies unsafe_code unless it's allowed locally, and progress_file became unused off Windows. 7b789dd adds #[allow(unsafe_code)] on current_euid (as window_capture.rs does) and the same cfg_attr(not(windows), allow(dead_code)) that run_tracked already has. Clippy is clean on Linux and Windows; macOS should follow in CI.

[thtbee]

Reviewed on the final branch along with the rest of the series: all findings addressed, the macOS stubs now build, and all nine checks pass on 7b789dd. Thank you, Jochen.