Repository navigation
fix(desktop): abstract open_folder across platforms and clean up native_window.h - #37
Merged
Merged
Conversation
…ve_window.h - Delegate photo backup folder opening to shell::open_folder across Windows (explorer.exe) and macOS (open) - Remove stray blank line in native_window.h from removed setScreenByName Signed-off-by: saivinay1805 <saivinayreddyvavilla@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24 addressing the two minor cleanups noted in #24 (review comment #24 (comment)):
desktop/app/src/bridge/photo_backup.rs): Replaced hard-codedexplorer.exeinvocation with platform-abstractedcrate::win::shell::open_folder(&folder).open_folderinmac/shell.rsusing macOSopento reveal the backup folder in Finder.open_folderinwin/shell.rsusingexplorer.exeon Windows.linux/shell.rsin PR feat(linux): Linux platform foundation, Qt6 windowing, and packaging (Part 1/6) #34.desktop/app/cpp/native_window.h): Removed the stray blank line left from the removedsetScreenByName, matchingmainexactly.Testing & Verification
cargo fmt --check && git diff --check: Cleancargo clippy --all-targets -- -D warnings: 0 warningscargo test --bin nectarlink-desktop -- --skip overwrites_clipboard: 164 passed, 0 failedcargo test -p nectarlink-core: 80 passed, 0 failedcargo test -p nectarlink-protocol: 62 passed, 0 failedSigned-off-by: saivinay1805 <saivinayreddyvavilla@gmail.com>).