Repository navigation
Conversation
MainWindow.qml stopped loading on main (fixed in e4b279a) and CI stayed green: the QML tests use stubs and can't load the app's windows, and the installer smoke test starts the app minimized. `nectarlink-desktop --ui-check --data-dir <dir>` starts the whole app on its own data, opens the main window, quits after 8 seconds and fails if QML reported a warning or an error, with Qt's messages on stderr instead of the log file. scripts/ui-check.ps1 runs it on the staged package, and the Windows CI job runs that after packaging. Checked locally: it fails on the MainWindow.qml from before e4b279a ("Cannot assign to non-existent property") and passes on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
MainWindow.qmlstopped loading on main after #29 (fixed in e4b279a), and CI stayed green: the QML tests use stubs and can't load the app's windows, and the installer smoke test starts the app minimized.nectarlink-desktop --ui-check --data-dir <dir>starts the whole app on its own data, opens the main window, quits after 8 seconds and exits with an error if QML reported a warning or an error. Qt's messages go to stderr instead of the log file. It refuses to run without--data-dir.scripts/ui-check.ps1runs it on the staged package with a fresh folder undertarget\ui-checkandNECTARLINK_NO_ADB=1.How it was tested
MainWindow.qmlfrom before e4b279a (Cannot assign to non-existent property "onWindowVisibilityChanged"), passes on main.cargo clippy -p nectarlink-desktop --all-targets -D warnings,cargo fmt --check, and the desktop tests (221, with a new one for the option).