Repository navigation
Use atomic writes for config file saves - #13
Merged
Merged
Conversation
Prevents partial writes and corruption of config.yaml when the process is interrupted mid-write or multiple CLI processes race on the same file. https://claude.ai/code/session_01JKkksiVQuP5HJVUshkmRS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement atomic writes for config file operations to prevent corruption from incomplete writes. The changes use a temporary file with
os.fsync()to ensure data is written to disk before atomically replacing the target config file withos.replace().This improves reliability when saving configuration, especially in scenarios with:
The
ensure_config_file()function now delegates tosave_config()to use the same atomic write mechanism.Testing
python -m pytestNotes
tempfile.mkstemp()to create a temporary file in the same directory as the target config file, ensuring they're on the same filesystem for atomicos.replace()