fixed readme to give correct location of file to edit for CMS#103
Open
krichey15 wants to merge 1 commit intothriveweb:masterfrom
krichey15:readme
Open
fixed readme to give correct location of file to edit for CMS#103krichey15 wants to merge 1 commit intothriveweb:masterfrom krichey15:readme
krichey15 wants to merge 1 commit intothriveweb:masterfrom
krichey15:readme
Conversation
|
👷 Deploy request for yellowcake pending review. 🔨 Explore the source changes: c77c13e |
|
You are completely right. Next time give credits at least... Original post where the issue was detected (by me): https://stackoverflow.com/a/67799072/5585371 |
Author
|
Oh I totally would have if I knew I should have. This is the first time I have made any kind of pull request on someone elses Repo. So in the future should I try to find the stackoverflow user who answered my question(you in this case)on github and give them credit in the pull request comment? I am not asking snidely just trying to learn best practice. |
mdazad1508
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current README file is not correct when it tells users to go to "Public/admin/config.yml" this file will be deleted upon running gatsby clean or on every new build.
Users should be going to "static/admin/config.yml" to make permanent changes to the CMS. I correct the readme to say this.