make cycleDetector.stopped atomic - #3591
Open
gzvolsky-tm wants to merge 1 commit into
Open
Conversation
Fixes the flaky build-darwin job and adds a regression test for the race with `go state.checkForCycles()` in `src/core/state.go`. The main goroutine can call Stop while the async check is in flight.
peterebden
requested changes
Sep 3, 2026
peterebden
left a comment
peterebden
left a comment
Collaborator
There was a problem hiding this comment.
I appreciate this, and it looks good, but I've addressed this in #3569 and would really like to get that reviewed and merged before making further changes to the existing setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky build-darwin job and adds a regression test for the race with
go state.checkForCycles()insrc/core/state.go. The main goroutine can call Stop while the async check is in flight.