Repository navigation
feat(O1): drivers 加車輛欄位(車種/車牌)+ migration 000017 - #29
Merged
Merged
Conversation
O 系列的地基:乘客端要顯示「搭什麼車」,且司機未填車輛資訊不得被派單(O3 gate)。 - migration 000017:vehicle_type/plate_number,沿用 drivers 慣例 TEXT NOT NULL DEFAULT '' - 車種存字串 + DB CHECK 限定白名單('', sedan, suv, van7, accessible, pet) 放資料層而非只在 API:它是清潔費(O6)與派單過濾(P3)的判斷依據,值髒掉直接影響計費 - internal/constants/vehicle.go:Go 端白名單;IsValidVehicleType 刻意不接受空字串, 避免 API 收到空值當合法而繞過 O3 gate - model.Driver 加欄位 + HasVehicle() 實作時定的兩件事(原規格留待拍板): 1. 車種存字串 + CHECK(非 smallint)——可讀性優先,報表/admin 直接看得懂 2. 車牌唯一性用 partial unique index(WHERE plate_number <> '') **不可用一般 UNIQUE**:既有司機 plate_number 全是 '', 一般唯一鍵會讓第二個未填車牌的司機直接插不進去 vehicle_color 不做(YAGNI,需求只要車種與車牌)。 驗收: - go build/vet 綠;constants 單元測試(白名單、防禦性副本) - 整合測試(真 PostGIS + 跑完整 migration): TestDriverVehicleSchema — 多筆空車牌不衝突/車牌非空時唯一/CHECK 擋非白名單 TestDriverVehicleMigrationReversible — up→down→再 up,欄位/CHECK/index 正確消失與回來 - 反向驗證:改成一般 UNIQUE → 空車牌案 FAIL;down 漏 DROP COLUMN → 可逆性測試 FAIL 順帶記錄:Postgres DROP COLUMN 會自動連帶刪除依賴的 CHECK/index, 故 down 的 DROP CONSTRAINT/INDEX 冗餘,保留僅為明示意圖。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
O 系列的地基,第一支實作 PR(前面都是規格)。乘客端要顯示「搭什麼車」,且司機未填車輛資訊不得被派單(O3 gate 的依據)。
000017:vehicle_type/plate_number,沿用 drivers 既有慣例TEXT NOT NULL DEFAULT '''', sedan, suv, van7, accessible, pet)internal/constants/vehicle.go:Go 端白名單model.Driver加欄位 +HasVehicle()實作時我必須定的兩件事(原規格留待拍板)
1. 車牌唯一性 → partial unique index(不是一般 UNIQUE)
規格原本建議
UNIQUE(plate_number),但那會炸:既有司機的plate_number全是'',一般唯一鍵會讓第二個未填車牌的司機直接插不進去——整個表加不了新司機。改用:已用測試釘住:反向驗證改成一般 UNIQUE,該案立刻 FAIL。
2. 車種存字串 + CHECK(非 smallint)
可讀性優先(admin/報表直接看得懂)。CHECK 放資料層而不只在 API 驗證——它是清潔費(O6)與派單過濾(P3)的判斷依據,值一旦髒掉會直接影響計費,最後防線該在 DB。
Go 端
IsValidVehicleType刻意不接受空字串,避免 API 收到空值就當合法而繞過 O3 gate。另外:
vehicle_color不做(YAGNI——需求只要求車種與車牌)。驗收
go build/go vet綠;internal/constants單元測試(白名單、防禦性副本)TestDriverVehicleSchema— 多筆空車牌不衝突/車牌非空時唯一/CHECK 擋非白名單TestDriverVehicleMigrationReversible— up → down → 再 up,欄位/CHECK/index 正確消失與回來DROP COLUMN→ 可逆性測試 FAIL過程中的一個發現
第一次反向驗證我讓 down 漏掉
DROP CONSTRAINT,預期會 FAIL——結果 PASS。原因是 Postgres 在DROP COLUMN時會自動連帶刪除依賴該欄位的 CHECK 與 index。所以 down 裡的DROP CONSTRAINT/DROP INDEX其實冗餘(保留只為明示意圖,IF EXISTS無害),而我的反向驗證挑錯了目標。改用「漏DROP COLUMN」重驗才確認測試真的有效。已記進 TODO。下一步
O2(
GET/PUT /api/driver/vehicle,含車牌格式驗證——O1 的 DB 層只保證唯一性、不驗格式)。🤖 Generated with Claude Code