Skip to content

Conversation

@JeffySam
Copy link

Description

This PR adds documentation for the migration of the
projects/index parent state from AngularJS to Angular.

Included documents

  • Projects Index Migration Investigation

    • Describes current migration status
    • Confirms Angular implementation completeness
    • Identifies legacy AngularJS files pending removal
    • Lists dependent child states and verification requirements
  • Projects Index Migration Plan

    • Defines verification steps before cleanup
    • Outlines safe removal of legacy files
    • Provides testing checklist and success criteria

Scope

  • Documentation only
  • No production code changes

Purpose

To provide clear technical context and a structured, low-risk path
to finalising the projects/index parent state migration.

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for thoth-tech ready!

Name Link
🔨 Latest commit 064620b
🔍 Latest deploy log https://app.netlify.com/projects/thoth-tech/deploys/697da2b9b348490008c3a8ae
😎 Deploy Preview https://deploy-preview-165--thoth-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@SteveDala SteveDala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JeffySam,

I checked out your changes locally. The content of the two documents seems a little trivial, but I think there's probably a place for this kind of process or action log. I don't think that place is in the root Markdown directory of src/content/docs; currently the only way to view your contribution is to directly navigate to /projects_index_migration_plan/, try this link to see what I'm talking about - or similar for your investigation document.

  1. Please try to find a new location for these two files, perhaps under src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration.

In addition, the table on the rendered page looks kind of bad:

Image

Notice the right-hand column extending all the way to the right of the container. This isn't your fault, but I think it should be fixed:

  1. You can find the custom CSS at src/content/styles/custom.css. Please add the following property and value inside the CSS rule for .sl-markdown-content table selector: max-width: max-content;

@JeffySam
Copy link
Author

hi @SteveDala Thanks for the review!

  • Moved both documents under:
    src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/
    so they’re no longer in the root docs directory.

  • Added max-width: max-content; to the
    .sl-markdown-content table rule in
    src/styles/custom.css to address the table layout issue you noted.

Copy link

@SteveDala SteveDala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a couple of nits. See below

verify that subscriptions are cleaned up correctly, and confirm that behaviour
matches the legacy implementation.

## Child State Verification Matrix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table that was previously here no longer exists. Was this intentional? If so, please remove this heading.


## Child State Verification Matrix

## Child State Verification Checklist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a checklist now, it would be better to fill in the checks with [x] so that it's clear these were checked as part of your process.

@JeffySam
Copy link
Author

@SteveDala Thanks for the follow-up!

  • Removed the leftover “Child State Verification Matrix” heading since the table was intentionally replaced.

  • Updated the verification checklist to use [x] to clearly indicate these checks were completed as part of the migration validation process.

Copy link

@SteveDala SteveDala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @BrianDangDev please proceed with an approving review to merge.

@JeffySam
Copy link
Author

Hi @SteveDala , quick heads-up — I removed the Units module docs from this PR as they’re meant for a separate documentation PR. The originally approved content is unchanged.

Could you please re-approve when you get a moment? Thanks!

@SteveDala
Copy link

As the content is not substantially different than my previous approval, the approval stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants