Repository navigation
Install the tool the licence step depends on - #1
Merged
Merged
Conversation
`npm run licenses` shells out to `cargo license`, which no GitHub runner image carries — so both jobs that regenerate the notices died on it. The release job never produced an installer at all, and the notices are the part the licences actually require to ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run licensesshells out tocargo license, which no GitHub runner image carries. Both jobs that regenerate the third-party notices died on it:bundlejob in CI, so no installer was ever produced frommain;releasejob, which failed on the manual dispatch at 16:20 today.The notices are the part MIT, BSD and ISC actually require to accompany the binary, so a release that skips them is not one worth publishing.
cargo install cargo-license --lockedbefore the step, in both workflows.🤖 Generated with Claude Code